Expose return value of dispatch call via trackEvent#91
Open
jmif wants to merge 2 commits intonytimes:mainfrom
Open
Expose return value of dispatch call via trackEvent#91jmif wants to merge 2 commits intonytimes:mainfrom
jmif wants to merge 2 commits intonytimes:mainfrom
Conversation
Collaborator
|
Nice. The use case makes sense 👍 Mind adding some docs and a test case please? |
|
Yes, some documentation would be great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to receive the result of the dispatch function in trackEvent calls.
Main use case for this is waiting to execute code until the event has been successfully tracked. Our tracking method inside of dispatch() returns a promise that resolves when the event has been successfully tracked.
We can use this to delay execution of events (for example exiting link clicks on critical events) until the event has tracked.